Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the expected DDL output value #5128

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix the expected DDL output value #5128

wants to merge 1 commit into from

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Nov 18, 2024 •
edited
Loading

The test source code uses -99.0:

Particle1 fill_data[1] = {{"no data", -1, -1, -99.0F, -99.0}};

I386 Alpine CI test needs this patch to pass all tests.

This change may fail some other 64-bit systems.
If so, I suspect a bug in the HDF5 library.

@hyoklee hyoklee added the Component - Testing Code in test or testpar directories, GitHub workflows label Nov 18, 2024
byrnHDF
byrnHDF requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@byrnHDF byrnHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct approach - why did this not fail until testing i386. First investigate the why of the failure.
And if i386 testing is correct and the 64-bit tests are correct - then add a special case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF requested changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Component - Testing Code in test or testpar directories, GitHub workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyoklee @byrnHDF