Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FUNC_ENTER macros to their own header files #4971

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Move FUNC_ENTER macros to their own header files #4971

wants to merge 5 commits into from

Conversation

derobins
Copy link
Member

  • Moves FUNC_ENTER/LEAVE macros into H5func_enter.h
  • Moves threadsafety FUNC_ENTER/LEAVE macros to H5func_enter_threadsafe.h
  • Cleans up FUNC_ENTER macros
  • Adds helpful documentation to FUNC_ENTER macros
  • Fix incorrect FUNC_ENTER macros in the main library

@derobins
Move FUNC_ENTER macros to their own header files
297a1df 
- Moves FUNC_ENTER/LEAVE macros into H5func_enter.h
- Moves threadsafety FUNC_ENTER/LEAVE macros to
  H5func_enter_threadsafe.h
- Cleans up FUNC_ENTER macros
- Adds helpful documentation to FUNC_ENTER macros
- Fix incorrect FUNC_ENTER macros in the main library
@derobins derobins added Priority - 2. Medium ⏹ It would be nice to have this in the next release Component - C Library Core C library issues (usually in the src directory) Type - Improvement Improvements that don't add a new feature or functionality Merge - To 2.0 This needs to be merged to HDF5 2.0 labels Oct 18, 2024
@qkoziol
Copy link
Contributor

qkoziol commented Oct 18, 2024

I definitely like the direction, with a couple of caveats:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjala mattjala mattjala approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Component - C Library Core C library issues (usually in the src directory) Merge - To 2.0 This needs to be merged to HDF5 2.0 Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derobins @qkoziol @mattjala