**** Possible FIXMEs / TODOs for the future

HBelusca · Oct 24, 2024 · e6a7608 · e6a7608
1 parent c7dfe28
commit e6a7608
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 2 deletions.
diff --git a/base/setup/lib/fsutil.c b/base/setup/lib/fsutil.c
@@ -831,6 +831,8 @@ FormatVolume(
         return Status;
 
     /* Set the new volume's file system and label */
+    // TODO: Here, call a volutil.c function that updates
+    // the actual FS name and the label fields of the volume.
     RtlStringCbCopyW(Volume->FileSystem, sizeof(Volume->FileSystem), FileSystemName);
     if (!Label) Label = L"";
     RtlStringCbCopyW(Volume->VolumeLabel, sizeof(Volume->VolumeLabel), Label);

diff --git a/base/setup/lib/setuplib.c b/base/setup/lib/setuplib.c
@@ -855,7 +855,7 @@ NTSTATUS
 InitDestinationPaths(
     _Inout_ PUSETUP_DATA pSetupData,
     _In_ PCWSTR InstallationDir,
-    _In_ PVOLENTRY Volume)
+    _In_ PVOLENTRY Volume)  // FIXME: HACK!
 {
     NTSTATUS Status;
     PPARTENTRY PartEntry = Volume->PartEntry;

diff --git a/base/setup/lib/setuplib.h b/base/setup/lib/setuplib.h
@@ -207,7 +207,7 @@ NTSTATUS
 InitDestinationPaths(
     _Inout_ PUSETUP_DATA pSetupData,
     _In_ PCWSTR InstallationDir,
-    _In_ PVOLENTRY Volume);
+    _In_ PVOLENTRY Volume); // FIXME: HACK!
 
 // NTSTATUS
 ERROR_NUMBER

diff --git a/base/setup/lib/utils/filesup.c b/base/setup/lib/utils/filesup.c
@@ -708,6 +708,9 @@ DoesPathExist_UStr(
                                RootDirectory,
                                NULL);
 
+    // Investigate: check for presence of FILE_ATTRIBUTE_DIRECTORY
+    // or FILE_ATTRIBUTE_REPARSE_POINT for directories?
+
     Status = NtOpenFile(&FileHandle,
                         IsDirectory ? (FILE_LIST_DIRECTORY | SYNCHRONIZE)
                                     :  FILE_GENERIC_READ, // Contains SYNCHRONIZE

diff --git a/base/setup/lib/utils/partlist.h b/base/setup/lib/utils/partlist.h
@@ -47,6 +47,8 @@ typedef struct _VOLENTRY
     VOLINFO Info;
     FORMATSTATE FormatState;
 
+/** The following properties may be replaced by flags **/
+
     /* Volume must be checked */
     BOOLEAN NeedsCheck;
     /* Volume is new and has not yet been actually formatted and mounted */
@@ -76,6 +78,8 @@ typedef struct _PARTENTRY
     ULONG PartitionIndex;        /* Index in the LayoutBuffer->PartitionEntry[] cached array of the corresponding DiskEntry */
     WCHAR DeviceName[MAX_PATH];  ///< NT device name: "\Device\HarddiskM\PartitionN"
 
+/** The following properties may be replaced by flags **/
+
     BOOLEAN LogicalPartition;
 
     /* Partition is partitioned disk space */