Skip to content

Commit

Permalink
[NTUSER] Remove a wrong check in MENU_MouseMove (reactos#5736)
Browse files Browse the repository at this point in the history
This check doesn't seem to be correct in modern ReactOS. Furthermore, it
actually hadn't been working for a long time until it was uncovered by
the recent system menu changes.

Reverts a hack introduced in 17a3152 (r72517), fixes CORE-19170.
The initial bug described in CORE-2338 is not observed.
  • Loading branch information
Cleverking2003 authored Oct 16, 2023
1 parent 13a145b commit e2d3aa7
Showing 1 changed file with 1 addition and 14 deletions.
15 changes: 1 addition & 14 deletions win32ss/user/ntuser/menu.c
Original file line number Diff line number Diff line change
Expand Up @@ -3683,20 +3683,7 @@ static BOOL FASTCALL MENU_MouseMove(MTRACKER *pmt, PMENU PtMenu, UINT Flags)
UINT Index = NO_SELECTED_ITEM;

if ( PtMenu )
{
if (IS_SYSTEM_MENU(PtMenu))
{
Index = 0;
//// ReactOS only HACK: CORE-2338
// Windows tracks mouse moves to the system menu but does not open it.
// Only keyboard tracking can do that.
//
TRACE("SystemMenu\n");
return TRUE; // Stay inside the Loop!
}
else
MENU_FindItemByCoords( PtMenu, pmt->Pt, &Index );
}
MENU_FindItemByCoords( PtMenu, pmt->Pt, &Index );

if (Index == NO_SELECTED_ITEM)
{
Expand Down

0 comments on commit e2d3aa7

Please sign in to comment.