**** Possible FIXMEs / TODOs for the future

HBelusca · Aug 21, 2024 · a7b8c37 · a7b8c37
1 parent 1e334cf
commit a7b8c37
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/base/setup/lib/fsutil.c b/base/setup/lib/fsutil.c
@@ -831,6 +831,8 @@ FormatVolume(
         return Status;
 
     /* Set the new volume's file system and label */
+    // TODO: Here, call a volutil.c function that updates
+    // the actual FS name and the label fields of the volume.
     RtlStringCbCopyW(Volume->FileSystem, sizeof(Volume->FileSystem), FileSystemName);
     if (!Label) Label = L"";
     RtlStringCbCopyW(Volume->VolumeLabel, sizeof(Volume->VolumeLabel), Label);

diff --git a/base/setup/lib/setuplib.c b/base/setup/lib/setuplib.c
@@ -797,7 +797,7 @@ NTSTATUS
 InitDestinationPaths(
     _Inout_ PUSETUP_DATA pSetupData,
     _In_ PCWSTR InstallationDir,
-    _In_ PVOLENTRY Volume)
+    _In_ PVOLENTRY Volume)  // FIXME: HACK!
 {
     NTSTATUS Status;
     PPARTENTRY PartEntry = Volume->PartEntry;

diff --git a/base/setup/lib/setuplib.h b/base/setup/lib/setuplib.h
@@ -206,7 +206,7 @@ NTSTATUS
 InitDestinationPaths(
     _Inout_ PUSETUP_DATA pSetupData,
     _In_ PCWSTR InstallationDir,
-    _In_ PVOLENTRY Volume);
+    _In_ PVOLENTRY Volume); // FIXME: HACK!
 
 // NTSTATUS
 ERROR_NUMBER

diff --git a/base/setup/lib/utils/partlist.h b/base/setup/lib/utils/partlist.h
@@ -47,6 +47,8 @@ typedef struct _VOLENTRY
     VOLINFO Info;
     FORMATSTATE FormatState;
 
+/** The following properties may be replaced by flags **/
+
     /* Volume must be checked */
     BOOLEAN NeedsCheck;
     /* Volume is new and has not yet been actually formatted and mounted */
@@ -75,6 +77,8 @@ typedef struct _PARTENTRY
     ULONG PartitionNumber;       /* Current partition number, only valid for the currently running NTOS instance */
     ULONG PartitionIndex;        /* Index in the LayoutBuffer->PartitionEntry[] cached array of the corresponding DiskEntry */
 
+/** The following properties may be replaced by flags **/
+
     BOOLEAN LogicalPartition;
 
     /* Partition is partitioned disk space */