Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only count assembly for size when no size present #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samfriedman
Copy link

Counting assembly bytes doesn't work properly for constant data in the .text section, which causes underreporting of sizes. The actual size reported by nm is present and accurate, so we prefer that and only count assembly bytes when nm doesn't give us a size.

@HBehrens
Copy link
Owner

This is absolutely the right thing to do, thank you @samfriedman ! Unfortunately, this change won't merge cleanly anymore. Unless you are volunteering to do so, I will rebase your change on top of master and write a test for it to prevent future regressions before merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants