Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to OpenGL4 #6

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Upgrade to OpenGL4 #6

wants to merge 13 commits into from

Conversation

Lunanne
Copy link
Member

@Lunanne Lunanne commented Oct 28, 2018

Includes the addition of GLM & GLEW. Didn't realize Deledrius was also working on that so it's probably best to wait with merging until after.

Copy link
Member

@Deledrius Deledrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After rebasing this to work from master, it compiles and runs, but the window only flashes briefly: the program exits through the "Failed to initialize GLEW" error path.

src/CMakeLists.txt Outdated Show resolved Hide resolved
src/graphics/imPipeline.cpp Show resolved Hide resolved
src/graphics/imPipeline.h Show resolved Hide resolved
src/graphics/imPipeline.h Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
src/Main.cpp Show resolved Hide resolved
@Deledrius Deledrius changed the title Upgrade to OpenGl4 Upgrade to OpenGL4 Oct 28, 2018
@Deledrius
Copy link
Member

Deledrius commented Oct 28, 2018

Upon further debugging, the GLEW error string returned is "Missing GL version". If I change the SDL_GL_CONTEXT_MAJOR_VERSION to 3 rather than 4, I finally receive a rendered screen containing the credits.

Looks like this is caused by a lack of support on my system for OGL 4.3, so I can't test the debug portion here.

Copy link
Member

@zrax zrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After doing some research, I found that SDL2's bundled cmake modules are very different depending on whether it was built with cmake or autotools. I feel like including a full FindSDL2.cmake is overkill for fixing this, so I may try to create a simpler solution to handle both versions in a separate Pull Request.

.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
libsquish/Makefile Outdated Show resolved Hide resolved
src/Main.cpp Outdated Show resolved Hide resolved
src/Main.cpp Outdated Show resolved Hide resolved
src/graphics/imPipeline.cpp Outdated Show resolved Hide resolved
src/graphics/imPipeline.cpp Outdated Show resolved Hide resolved
src/graphics/imPipeline.cpp Outdated Show resolved Hide resolved
src/graphics/imPipeline.cpp Outdated Show resolved Hide resolved
@Lunanne
Copy link
Member Author

Lunanne commented Nov 14, 2018

@zrax is there a name for the specific indent style that you want? I'm having trouble configuring Clion to format it correctly and I would like to save us some time in the future

src/Main.cpp Outdated Show resolved Hide resolved
src/Main.cpp Outdated Show resolved Hide resolved
src/Main.cpp Show resolved Hide resolved
src/graphics/imPipeline.cpp Outdated Show resolved Hide resolved
src/graphics/imPipeline.cpp Outdated Show resolved Hide resolved
src/graphics/imPipeline.h Outdated Show resolved Hide resolved
src/Main.cpp Outdated Show resolved Hide resolved
src/Main.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants