-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to OpenGL4 #6
base: master
Are you sure you want to change the base?
Conversation
Update SDL to SDL2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After rebasing this to work from master, it compiles and runs, but the window only flashes briefly: the program exits through the "Failed to initialize GLEW" error path.
Upon further debugging, the GLEW error string returned is "Missing GL version". If I change the Looks like this is caused by a lack of support on my system for OGL 4.3, so I can't test the debug portion here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After doing some research, I found that SDL2's bundled cmake modules are very different depending on whether it was built with cmake or autotools. I feel like including a full FindSDL2.cmake is overkill for fixing this, so I may try to create a simpler solution to handle both versions in a separate Pull Request.
@zrax is there a name for the specific indent style that you want? I'm having trouble configuring Clion to format it correctly and I would like to save us some time in the future |
Includes the addition of GLM & GLEW. Didn't realize Deledrius was also working on that so it's probably best to wait with merging until after.