Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsed and Expand events based on elemental2.dom.MutationObserver #789

Open
wants to merge 2 commits into
base: release_2.1
Choose a base branch
from

Conversation

d-eggert
Copy link

- added elemental2.dom.Dom dependency
- disabled non working tests
*/
private Object onMutation(MutationRecord[] records) {
for (MutationRecord r : records) {
System.out.println(r.target.nodeName + " " + r.attributeName + ": " + r.oldValue + " type: " + r.type);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be removed 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup agreed we must remove any debug logs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups, missed that one. sorry.

@d-eggert
Copy link
Author

Does one of you have an idea for fixing the test case?

@kevzlou7979
Copy link
Contributor

Might need to check this tomorrow, as I am on Addins for today for fixing the bugs.

@kevzlou7979
Copy link
Contributor

This pull request should be merge later on 2.2 branch. I will create a branch for it later. Because elemental2 shouldnt be included in 2.1 - as we might have an internal changes like dom.elements etc.

@kevzlou7979
Copy link
Contributor

We plan to migrate our GMD widget to elemental on 2.6.0 release

@kevzlou7979 kevzlou7979 added this to the Release 2.6.0 milestone Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants