Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native Android Friendly #5

Merged
merged 1 commit into from
Mar 22, 2018

Conversation

brentkirkland
Copy link
Contributor

For in loops break RN Android...
Was wondering your thoughts on making the for in loop a traditional loop
Seems like others experience similar issues.
nicolaslopezj/meteor-apollo-accounts#73

@GuillaumeCisco
Copy link
Owner

Very interesting error with react native on android. And weird that they does not create a check for including Symbol polyfill on compilation/interpretation...
I have absolutely no opposition of using a traditional loop.
Will merge it, Thank you for your PR.

This will be deployed in the day on npm ;)

@GuillaumeCisco GuillaumeCisco merged commit f4dde78 into GuillaumeCisco:master Mar 22, 2018
@brentkirkland
Copy link
Contributor Author

Yes very weird...

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants