Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump csharpier from 0.29.2 to 0.30.1 #465

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 18, 2024

Bumps csharpier from 0.29.2 to 0.30.1.

Release notes

Sourced from csharpier's releases.

0.30.0

Breaking Changes

The CSharpier dotnet tool no longer supports net6 & net7.

What's Changed

Support C# 13 & dotnet 9. #1318

CSharpier now supports dotnet 9 along with formatting all C# 13 language features.

Inconsistent Formatting for new() Operator Compared to Explicit Object Constructors #1364

Implicit and explicit object initialization with constructors was not formatted consistently

// input & expected output
SomeObject someObject = new(
    someLongParameter___________________,
    someLongParameter___________________
)
{
    Property = longValue_______________________________________________________________________,
};
SomeObject someObject = new SomeObject(
someLongParameter___________________,
someLongParameter___________________
)
{
Property = longValue_______________________________________________________________________,
};
// 0.29.2
SomeObject someObject =
new(someLongParameter___________________, someLongParameter___________________)
{
Property = longValue_______________________________________________________________________,
};
SomeObject someObject = new SomeObject(
someLongParameter___________________,
someLongParameter___________________
)
{
Property = longValue_______________________________________________________________________,
};

Adds additional space before each member access in verbatim interpolated multiline string #1358

When an interpolated verbatim string contained line breaks, the code within the interpolations would contain extra spaces.

// input & expected output
var someStringWithLineBreakAndLongValue =
    $@"
{someValue.GetValue().Name} someLongText________________________________________________________________";
</tr></table>

... (truncated)

Changelog

Sourced from csharpier's changelog.

# 0.30.1

What's Changed

Revert tool command back to dotnet-csharpier, it was supposed to be changed to csharpier for 1.0.0

0.30.0

Breaking Changes

The CSharpier dotnet tool no longer supports net6 & net7.

What's Changed

Support C# 13 & dotnet 9. #1318

CSharpier now supports dotnet 9 along with formatting all C# 13 language features.

Inconsistent Formatting for new() Operator Compared to Explicit Object Constructors #1364

Implicit and explicit object initialization with constructors was not formatted consistently

// input & expected output
SomeObject someObject = new(
    someLongParameter___________________,
    someLongParameter___________________
)
{
    Property = longValue_______________________________________________________________________,
};
SomeObject someObject = new SomeObject(
someLongParameter___________________,
someLongParameter___________________
)
{
Property = longValue_______________________________________________________________________,
};
// 0.29.2
SomeObject someObject =
new(someLongParameter___________________, someLongParameter___________________)
{
Property = longValue_______________________________________________________________________,
};
SomeObject someObject = new SomeObject(
someLongParameter___________________,
someLongParameter___________________
)
{
Property = longValue_______________________________________________________________________,
};

Adds additional space before each member access in verbatim interpolated multiline string #1358

When an interpolated verbatim string contained line breaks, the code within the interpolations would contain extra spaces.

// input & expected output
</tr></table> 

... (truncated)

Commits
  • fedc791 Releasing 0.30.1 (#1384)
  • 6375fab revert tool command, this was supposed to be in 1.0.0 only (#1383)
  • 0425539 Releasing 0.30.0 (#1381)
  • 4dfa243 Ensure we are ready for the next major version. (#1380)
  • 1c76620 Update Editors.md with conform.nvim suggestion for Neovim (#1379)
  • cfb0a03 use 0.29.2 and fix the 0.0.1 warning
  • 91bbafb Fixing extra line + indent with collection expression on fields (#1371)
  • b14d79f Fixing issue with a trailing comma being added after a trailing comment (#1370)
  • 13cd0c0 fix: remove extra hyphen in troubleshooting step file (#1372)
  • 42622cd fix extra space being added in invocation that is inside verbatim str… (#1373)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @guibranco.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Build:

  • Update csharpier version from 0.29.2 to 0.30.1 in the dotnet-tools configuration.

Bumps [csharpier](https://github.com/belav/csharpier) from 0.29.2 to 0.30.1.
- [Release notes](https://github.com/belav/csharpier/releases)
- [Changelog](https://github.com/belav/csharpier/blob/main/CHANGELOG.md)
- [Commits](belav/csharpier@0.29.2...0.30.1)

---
updated-dependencies:
- dependency-name: csharpier
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies nuget NuGet package labels Nov 18, 2024
@dependabot dependabot bot requested a review from guibranco November 18, 2024 11:35
Copy link

korbit-ai bot commented Nov 18, 2024

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

Copy link

semanticdiff-com bot commented Nov 18, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  .config/dotnet-tools.json  0% smaller

Copy link

pr-code-reviewer bot commented Nov 18, 2024

👋 Hi there!

Update the "csharpier" tool version from "0.29.2" to "0.30.1". Ensure that the version change aligns with compatibility and desired features. Verify that the "dotnet-csharpier" command functions correctly with the updated version.


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at [email protected].

Copy link

Potential issues, bugs, and flaws that can introduce unwanted behavior:

  1. Version Compatibility:
    /.config/dotnet-tools.json - Changing the version from "0.29.2" to "0.30.1" might introduce breaking changes if the new version has significant alterations or deprecated features that your codebase relies on. Test your codebase thoroughly after upgrading to ensure compatibility.

Code suggestions and improvements for better exception handling, logic, standardization, and consistency:

  1. Change Locking:
    /.config/dotnet-tools.json - Maintain a version lock or use a specific versioning strategy to ensure that version upgrades do not lead to unintended issues in a production environment. Consider documenting the change or running integration tests to verify that the new version behaves as expected.

Copy link

sourcery-ai bot commented Nov 18, 2024

Reviewer's Guide by Sourcery

This PR updates the CSharpier code formatting tool from version 0.29.2 to 0.30.1. The update includes breaking changes regarding .NET framework support, adds C# 13 and .NET 9 support, and fixes several formatting inconsistencies. The implementation is straightforward, only requiring a version bump in the dotnet-tools.json configuration file.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update CSharpier version in dotnet tools configuration
  • Bump version from 0.29.2 to 0.30.1
  • Maintain existing command configuration for dotnet-csharpier
.config/dotnet-tools.json
Notable changes included in the version update
  • Drop support for .NET 6 and .NET 7
  • Add support for C# 13 language features and .NET 9
  • Fix inconsistent formatting between implicit and explicit object initialization
  • Fix extra spacing issues in verbatim interpolated multiline strings
.config/dotnet-tools.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

coderabbitai bot commented Nov 18, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

instapr bot commented Nov 18, 2024

Feedback on PR

  1. Ensure to update the CHANGELOG section with the latest information related to the changes made in the CSharpier tool.
  2. Make sure all the Commits related to this update are concise and follow the project's guidelines.

Thank you for the contribution!

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!

@guibranco guibranco enabled auto-merge (squash) November 18, 2024 11:35
@gstraccini gstraccini bot added the ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) label Nov 18, 2024
@gstraccini gstraccini bot added the 🤖 bot Automated processes or integrations label Nov 18, 2024
Copy link
Member

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@guibranco
Copy link
Member

@dependabot squash and merge

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 18, 2024

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Copy link
Contributor

Build debug & Version bump: 👽 Not building GHActionsCI.sln, no source files changed.

Copy link
Contributor

Infisical secrets check: ✅ No secrets leaked!

💻 Scan logs
12:19PM INF scanning for exposed secrets...
12:19PM INF 307 commits scanned.
12:19PM INF scan completed in 572ms
12:19PM INF no leaks found

@guibranco guibranco merged commit 5468c42 into main Nov 18, 2024
17 of 18 checks passed
@guibranco guibranco deleted the dependabot/nuget/csharpier-0.30.1 branch November 18, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) 🤖 bot Automated processes or integrations dependencies .NET Pull requests that update .net code nuget NuGet package size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant