Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display more context on binary exit #114

Merged
merged 1 commit into from
Aug 7, 2023
Merged

feat: display more context on binary exit #114

merged 1 commit into from
Aug 7, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Aug 7, 2023

closes #110

Two changes:

  • change pid from pid file to the real pid
  • display pid and start args on exit

@waynexia
Copy link
Member Author

waynexia commented Aug 7, 2023

It now looks like
image

shawnh2
shawnh2 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. can merge it right now.

notice: when you exit the gtctl, the cluster (include log file) will also be deleted. so for those users who want the logs remain, consider add a RetainLogs option for bare-metal mode. I'm working on this right now.

@waynexia
Copy link
Member Author

waynexia commented Aug 7, 2023

notice: when you exit the gtctl, the cluster (include log file) will also be deleted. so for those users who want the logs remain, consider add a RetainLogs option for bare-metal mode. I'm working on this right now.

Just run into this problem lol

zyy17
zyy17 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't believe you become the Gopher 😊

@zyy17 zyy17 merged commit f3335c5 into develop Aug 7, 2023
6 checks passed
@zyy17 zyy17 deleted the log-on-error branch August 7, 2023 08:46
@shawnh2 shawnh2 mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyy17 zyy17 zyy17 approved these changes

@shawnh2 shawnh2 shawnh2 approved these changes

@daviderli614 daviderli614 Awaiting requested review from daviderli614

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display more context on exit error
3 participants
@waynexia @zyy17 @shawnh2