Add methods to change a material's composition #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachy84
requested changes
Oct 7, 2024
bruberu
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
For Addon/Modpack devs, it's unfortunate to not have a way of changing a material's composition. Autogenerated recipes obviously work with the composition and not the chemical formula of a material, so to prevent the need of adding the disable decomposition flag and a new decomposition recipe for materials with changed formula alone, it's more reasonable to just change the composition in the first place.
Implementation Details
Please check whether I used the ZenMethod annotation correctly.
Outcome
Some Addon/Modpack devs will be happy.