Optimize JEI multiblock preview allocations #2629
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruberu
approved these changes
Oct 9, 2024
…timize # Conflicts: # src/main/java/gregtech/api/terminal/gui/widgets/MachineSceneWidget.java # src/main/java/gregtech/common/terminal/app/multiblockhelper/MachineBuilderWidget.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes
WorldSceneRendererto use aSet<BlockPos>instead of a strange map, and usesSet#containsinstead of a stream forTrackedDummyWorld'srenderFilterpredicate. This drastically reduces allocations in multiblock previews.Outcome
Improves multiblock preview rendering performance.
Additional Information
This change breaks rendering in the terminal's auto build UI such that it does not display blocks after it auto places. I did not notice any change in the AR preview. Both of these are in a deprecated/soon to be removed state, so this should be fine for now.