-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantum Chest Voiding + Quantum Storage Improvements #2078
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghzdude
force-pushed
the
gh-qchest-improvements
branch
from
September 22, 2023 23:00
07e206a
to
adc9602
Compare
ghzdude
force-pushed
the
gh-qchest-improvements
branch
from
November 2, 2023 02:46
adc9602
to
ee38b1b
Compare
18 tasks
src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityQuantumChest.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityQuantumChest.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityQuantumChest.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityQuantumChest.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityQuantumChest.java
Show resolved
Hide resolved
rename button_void to button_fluid_void
count is set to 1 to prevent byte overflow
optimize imports
ghzdude
force-pushed
the
gh-qchest-improvements
branch
from
November 7, 2023 20:28
3c89d3a
to
d45897f
Compare
While messing around with the quantum chests, I have noticed something. It is possible for items to be incorrectly voided when using auto output and item pipes. I think this might be because of the item pipes, as placing quantum chests directly next to each other does not have this issue. I'm also not 100% sure how to reproduce this issue, but it involves trying to send items using auto output to another quantum chest. |
improve some tests
…ory` add methods to retrieve those handlers
that's handled by `combinedInventory`
add test for inserting when near full add method for extracting from all handler slots
ghzdude
changed the title
Quantum Chest Voiding + Improvements
Quantum Chest Voiding + Quantum Storage Improvements
Nov 9, 2023
TechLord22
reviewed
Nov 12, 2023
src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityQuantumChest.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityQuantumChest.java
Show resolved
Hide resolved
src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityQuantumChest.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityQuantumChest.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityQuantumChest.java
Outdated
Show resolved
Hide resolved
src/test/java/gregtech/common/metatileentities/storage/QuantumChestTest.java
Outdated
Show resolved
Hide resolved
src/test/java/gregtech/common/metatileentities/storage/QuantumChestTest.java
Outdated
Show resolved
Hide resolved
serenibyss
reviewed
Nov 12, 2023
serenibyss
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR primarily adds voiding functionality to the quantum chest, pulled from #1963. This also improves the quantum chest handler logic and makes it so the import slot can only accept items that match the items in the export slot. Also adds a unique texture and lang for the item voiding button. Now fixes most of #2142, and this pr should be pulled in after #2143
Also adds tests for Quantum chests/tank handler logic.
Adds voiding for both quantum chests/tanks to packet to sync client with server.
pretty much touches all of qchest logic (hopefully for the last time)
Implementation Details
rename "BUTTON_VOID" to seperate fluid and item variants
show item name if an item is in export slot
try to compress name if it's too long
make sure excess items don't remain in the import slot
adds a new dataid
UPDATE_IS_VOIDING
updates voiding on client to match server
Outcome
qchest can void items just like fluid qtanks voids fluid
qchests logic is somewhat more comprehensible
Potential Compatibility Issues
none afaik