Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantum Chest Voiding + Quantum Storage Improvements #2078

Merged
merged 57 commits into from
Nov 12, 2023

Conversation

ghzdude
Copy link
Contributor

@ghzdude ghzdude commented Sep 11, 2023

What

This PR primarily adds voiding functionality to the quantum chest, pulled from #1963. This also improves the quantum chest handler logic and makes it so the import slot can only accept items that match the items in the export slot. Also adds a unique texture and lang for the item voiding button. Now fixes most of #2142, and this pr should be pulled in after #2143

Also adds tests for Quantum chests/tank handler logic.

Adds voiding for both quantum chests/tanks to packet to sync client with server.
pretty much touches all of qchest logic (hopefully for the last time)

Implementation Details

rename "BUTTON_VOID" to seperate fluid and item variants
show item name if an item is in export slot
try to compress name if it's too long
make sure excess items don't remain in the import slot
adds a new dataid UPDATE_IS_VOIDING
updates voiding on client to match server

Outcome

qchest can void items just like fluid qtanks voids fluid
qchests logic is somewhat more comprehensible

Potential Compatibility Issues

none afaik

@ghzdude ghzdude added the type: feature New feature or request label Sep 11, 2023
@ghzdude ghzdude requested a review from a team as a code owner September 11, 2023 22:44
@TechLord22 TechLord22 added this to the 2.8 milestone Sep 23, 2023
@ghzdude ghzdude changed the base branch from master to 2.8 November 2, 2023 02:51
@ghzdude ghzdude linked an issue Nov 2, 2023 that may be closed by this pull request
@ghzdude
Copy link
Contributor Author

ghzdude commented Nov 7, 2023

While messing around with the quantum chests, I have noticed something.

It is possible for items to be incorrectly voided when using auto output and item pipes. I think this might be because of the item pipes, as placing quantum chests directly next to each other does not have this issue. I'm also not 100% sure how to reproduce this issue, but it involves trying to send items using auto output to another quantum chest.

@ghzdude ghzdude changed the title Quantum Chest Voiding + Improvements Quantum Chest Voiding + Quantum Storage Improvements Nov 9, 2023
@TechLord22 TechLord22 merged commit b1e2937 into GregTechCEu:2.8 Nov 12, 2023
2 checks passed
@ghzdude ghzdude deleted the gh-qchest-improvements branch February 19, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several issues with Quantum Chests on master/2.8
4 participants