Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: added regex validation for version name formatting #1789

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

jersey1dev
Copy link
Contributor

Description

[comment]: Propose fix to issue #1781

Fixes #1781

Type of change

  • [X ] Bug fix (non-breaking change which fixes an issue)

Checklist:

Ran relevant checks

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dadiorchen
Copy link
Collaborator

This looks good, @1nzexi did you try to run it?

@jersey1dev
Copy link
Contributor Author

Yes, I did. But to be honest, I just manually provided git tags such as v2.9.3 which the CI rejects and tags such as 2.9.3 which the CI currently accepts. But obviously, this test isn't robust. Do you need me write more comprehensive tests? If so, where can I add code for them? Or are there more requirements to the version number than just rejecting version number that precedes with v?

@dadiorchen dadiorchen merged commit 292e998 into Greenstand:main Jul 2, 2024
3 checks passed
@dadiorchen
Copy link
Collaborator

@1nzexi this is enough, we don't have good way to write test for ci / actions, so manually test is the only way I can imagine, also you can bring suggestion on how to test CI

@jersey1dev
Copy link
Contributor Author

jersey1dev commented Jul 2, 2024

@1nzexi this is enough, we don't have good way to write test for ci / actions, so manually test is the only way I can imagine, also you can bring suggestion on how to test CI

I could try using a repo called act, which has the capabiity of running actions locally and see if it brings any benefits to testing github action scripts. But I do think it is just a convenience utility which allows developers to run github actions locally, instead of being a testing framework for actions.

Copy link

🎉 This PR is included in version 2.9.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve this github action by adding version checking.
2 participants