Improve .gdextension and binary files naming #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a 'lib' prefix to the library name, as it seems common usage, and had issues without it.
Also modified the macos and ios destination paths and .gdextension accordingly.
Needs testing, really not sure if this works right now.
To test the correctness of library paths in the CI, we should download Godot through some action, and then run a headless instance to check any errors (gdUnit4 could do that #5).
A loose reference is the godot-cpp-template repo:
https://github.com/godotengine/godot-cpp-template/blob/main/SConstruct
https://github.com/godotengine/godot-cpp-template/blob/main/demo/bin/example.gdextension