Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cat devel merger 2 #87

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Cat devel merger 2 #87

merged 3 commits into from
Oct 12, 2023

Conversation

vcatlett
Copy link
Contributor

GUI code (dysh/gui/), minor .gitignore changes for my own sanity, docs on building the GUI with PyInstaller

@vcatlett vcatlett requested a review from mpound October 11, 2023 21:07
@vcatlett vcatlett temporarily deployed to hatch build October 11, 2023 21:07 — with GitHub Actions Inactive
@vcatlett vcatlett temporarily deployed to hatch build October 11, 2023 21:07 — with GitHub Actions Inactive
@vcatlett vcatlett temporarily deployed to hatch build October 11, 2023 21:07 — with GitHub Actions Inactive
@vcatlett vcatlett temporarily deployed to hatch build October 11, 2023 21:07 — with GitHub Actions Inactive
@vcatlett vcatlett temporarily deployed to hatch build October 11, 2023 21:07 — with GitHub Actions Inactive
@vcatlett vcatlett temporarily deployed to hatch build October 11, 2023 21:07 — with GitHub Actions Inactive
@vcatlett vcatlett temporarily deployed to hatch build October 11, 2023 21:07 — with GitHub Actions Inactive
@vcatlett vcatlett temporarily deployed to hatch build October 11, 2023 21:07 — with GitHub Actions Inactive
@vcatlett vcatlett temporarily deployed to hatch build October 11, 2023 21:07 — with GitHub Actions Inactive
@vcatlett vcatlett temporarily deployed to hatch build October 11, 2023 21:07 — with GitHub Actions Inactive
@vcatlett vcatlett temporarily deployed to hatch build October 11, 2023 21:07 — with GitHub Actions Inactive
@vcatlett vcatlett temporarily deployed to hatch build October 11, 2023 21:07 — with GitHub Actions Inactive
vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
.gitignore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed these lines because it was blocking my gui/build docs directory. Doesn't really matter if the PyInstaller-generated directories get added by accident.

vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
docs/source/gui/build/executable.rst
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs page about building the executable with PyInstaller

vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
docs/source/gui/build/index.rst
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs index for the new gui/build docs directory

vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
gui/app.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main GUI script

vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
gui/static/favicon.ico
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon for the executable

vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
gui/tests/.gitkeep
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitkeep so the folder structure shows up

vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
gui/util/__init__.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯_(ツ)_/¯

vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
gui/util/core.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worker objects

vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
gui/util/dataload.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classes to load the data files with dysh

vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
gui/widgets/QIPython.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python console interactions

vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
gui/widgets/__init__.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯_(ツ)_/¯

vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
gui/widgets/graphs.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graph widgets that can be filled with data and imported into layouts

vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
gui/widgets/layouts.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom layout widgets

vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
gui/widgets/splash.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splash screen for when stuff is loading

vcatlett
vcatlett commented Oct 11, 2023
View reviewed changes
gui/widgets/tables.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom table widgets

mpound
mpound approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@mpound mpound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will accept these changes so you can move forward. However, my main concern is the lack of in-line documentation on the classes and methods. Please spend some time documenting the code, especially methods that take parameters.

@mpound mpound merged commit 2200da1 into release-0.2.0 Oct 12, 2023
12 checks passed
@vcatlett vcatlett deleted the cat-devel-merger-2 branch October 18, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpound mpound mpound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vcatlett @mpound