440 implement aperture efficiency calculations #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso 2 rows are apparently for 22GHz not 43.
astrofle
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the calculation and testing of aperture efficiency, surface error, gain correction as function of zenith distance. New class
BaseGainCorrectionis an abstract base class to be used by telescope specific gain correction classes,GBTGainCorrectionis the GBT-specific class. Important coefficients and constants are stored in an ASCII configuration file. Test code is in test_gaincorrection.pyThis PR also includes a new dysh/conf directory where configuration tables are to be stored. (The first is the gain correction table). util code gets the conf path:
get_project_configuration()Not included in this PR is any change to the calibration routines to use these classes.