303 documentation or code error for vel frame #439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
velocity_frame
attribute of Spectrum.Although this is the desired behavior in the issue report, I am not entirely convinced this is behavior we want, because it is special casing one type of call to plot(). However, if
Spectrum.velocity_frame
was changed by the user via dysh (e.g.Spectrum.set_frame
), then VELDEF will also get changed the behavior should still match user expectations.