Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 245 #438

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Issue 245 #438

merged 3 commits into from
Dec 9, 2024

Conversation

astrofle
Copy link
Collaborator

@astrofle astrofle commented Dec 6, 2024 •
edited
Loading

This PR is a fix for #245 :

  • Fixes an issue where copying a BaseSelection object would not preserve the indices of its _table.
  • Removes the version cap for astropy.
  • Points pytest to run notebooks/examples and not docs to avoid running notebook tests twice.

@astrofle astrofle linked an issue Dec 6, 2024 that may be closed by this pull request
use of Table.loc fails for astropy 6.1.0 #245
Closed
@astrofle astrofle marked this pull request as ready for review December 6, 2024 03:47
@astrofle astrofle requested a review from mpound December 6, 2024 03:47
@mpound mpound merged commit 7202974 into main Dec 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpound mpound mpound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use of Table.loc fails for astropy 6.1.0
2 participants
@astrofle @mpound