Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 336 #433

Merged
merged 10 commits into from
Dec 2, 2024
Merged

Issue 336 #433

merged 10 commits into from
Dec 2, 2024

Conversation

astrofle
Copy link
Collaborator

@astrofle astrofle commented Dec 2, 2024

In this PR:

  • Changes to custom.css to use the same background color on all cells (so far). Fixes issue Notebook download outputs have white background in dark mode #336.
  • Updates to flagging notebook to show how to use GBTFITSLoad.clear_flags method.
  • Removes transition (horizontal rule) at beginning of notebooks.
  • Fixes to some of the docstrings that caused parsing errors.
  • Add use of logger to dysh.util.download.
  • Add sphinx-copybutton so that code cells can be copied with a click.

@astrofle astrofle requested a review from mpound December 2, 2024 20:37
@astrofle astrofle linked an issue Dec 2, 2024 that may be closed by this pull request
Notebook download outputs have white background in dark mode #336
Closed
mpound
mpound approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@mpound mpound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@astrofle astrofle merged commit 2275284 into main Dec 2, 2024
11 checks passed
@astrofle astrofle deleted the issue_336 branch December 2, 2024 21:38
@astrofle astrofle mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpound mpound mpound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notebook download outputs have white background in dark mode
2 participants
@astrofle @mpound