Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 254 #420

Merged
merged 9 commits into from
Nov 1, 2024
Merged

Issue 254 #420

merged 9 commits into from
Nov 1, 2024

Conversation

astrofle
Copy link
Collaborator

@astrofle astrofle commented Oct 30, 2024 •
edited
Loading

In this PR

  • The following scans now ignore blanked integrations: FSScan, PSScan, NodScan (TPScan already had this, and SubBeamNodScan uses TPScan)
  • Minor fix in PSScan where sigcalon data did not get the mask applied.

@astrofle astrofle marked this pull request as ready for review October 30, 2024 16:45
@astrofle astrofle linked an issue Oct 30, 2024 that may be closed by this pull request
Descriptive error/warning message for blank integrations #254
Closed
@astrofle astrofle self-assigned this Oct 30, 2024
@astrofle astrofle requested a review from mpound October 30, 2024 16:46
mpound
mpound approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@mpound mpound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. Thanks for catching the missing mask, too!

@astrofle astrofle mentioned this pull request Nov 1, 2024
Open
@astrofle astrofle merged commit b4ae7ab into main Nov 1, 2024
11 checks passed
@astrofle astrofle deleted the issue_254 branch November 1, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpound mpound mpound approved these changes

Assignees

@astrofle astrofle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Descriptive error/warning message for blank integrations
2 participants
@astrofle @mpound