Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.9 #406

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Drop support for Python 3.9 #406

merged 7 commits into from
Oct 25, 2024

Conversation

tchamberlin
Copy link
Member

@tchamberlin tchamberlin commented Oct 16, 2024

specutils has dropped support for Python 3.9. So, we will do the same

Note that per this spec, https://scientific-python.org/specs/spec-0000/ , we should drop support for Python 3.10 as of Q4 2024 (now). But I don't see any good reason for doing that, as it isn't really adding any maintenance burden and I haven't heard anyone clamoring for new 3.10+ specific features yet

@tchamberlin tchamberlin requested a review from mpound October 16, 2024 19:27
@tchamberlin
Copy link
Member Author

It does not appear possible to use Python 3.13 using our maximum supported Astropy version. I don't think it's worth trying to understand why; we have no mandate to support 3.13 yet. So instead I have explicitly dropped support for Python 3.13+ in pyproject.toml

I have also regenerated our lock file (requirements.txt). But no Python dependency pins have changed

@tchamberlin tchamberlin changed the title Drop support for Python 3.9, add support for Python 3.13 Drop support for Python 3.9 Oct 16, 2024
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@mpound mpound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflicts need to be cleaned up but it looks good!

@tchamberlin tchamberlin merged commit 4ea555e into main Oct 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants