-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dysh data2 simplify data filenames #394
Conversation
Can you merge the latest version of |
main is merged, only saw src/dysh/shell/shell.py and src/dysh/spectra/scan.py |
For what it's worth, we did remove |
the current dysh_data() still has some wget in it, but of course this would only work for actual fits files, not for datasets with multi-fits contents. The example notebooks all are using from_url now. My problem with those is that it will often trigger a download, but i have my data in $DATA_DYSH, and so I'd rather have a frontend for this from_url function. For example, in the PS example notebook we currently have
and this would be replaced by
though one can also use full example names like
|
Apologies for my delay; I just returned from some sick leave. It looks like there are now some merge conflicts which need to be resolved. Peter, can you take a look at those? I can help you make the changes if needed. |
Although this will not be the final version, pending some discussion particularly on how to configure it in production time, there was a need to simplify filenames that work across being at GBO or on a laptop. The current solution is to provide an environment variable $DYSH_DATA within which directories (or symlinks) to places like example_data, acceptance_testing etc.
I'd like this merged into main sooner than later, since the nodding code testing (which has 10 examples) now depends on keeping filename easy to manage across sites.