Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: gettp does not separate IFs #388

Merged
merged 60 commits into from
Oct 9, 2024
Merged

Fix: gettp does not separate IFs #388

merged 60 commits into from
Oct 9, 2024

Conversation

astrofle
Copy link
Collaborator

Fixes issue #361

teuben and others added 13 commits September 17, 2024 16:08
@teuben
add dysh_data (copy from the dysh_data branch)
02107e6
@teuben
test 10 different nodding examples (nod0..nod9) though some of them h…
6359359 
…ave issues
@teuben
Merge remote-tracking branch 'origin/dysh_data2' into nodding2
0142c3a
@teuben
reorder to gettp() getps() getfs() to be consistent with scan.py
6e17d57
@teuben
add a ps=False option to getnod() to get a BS mode
aa28469
@teuben
add debugging, add the true sdf.getnod()
c6329ee
@teuben
add a simple NODScan(), though this one still keeps one scanblock per…
0639df6 
… scan
@teuben
implement getnod() for TP based data. this one still keeps a scanbloc…
2ef7b8c 
…k per scan, they need to be merged
@astrofle
Fix: removes leftover print statements
1885061
@teuben
make beam1 and beam2 signals positive
bb19c4d
@teuben
more examples straight from the large files via scan/ifnum/plnum sele…
aeb8441 
…ction
@astrofle
Merge branch 'main' into logging_cleanup_1
ecf5066
@astrofle
Fix: gettp does not separate IFs
d649e47
@astrofle astrofle requested a review from mpound September 24, 2024 19:45
@astrofle astrofle mentioned this pull request Sep 24, 2024
Closed
@astrofle astrofle linked an issue Sep 24, 2024 that may be closed by this pull request
gettp() does not separate the IF's in a nodding example #361
Closed
mpound
mpound approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@mpound mpound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@astrofle
Copy link
Collaborator Author

This touches GBTFITSLoad so I'll wait for Peter's nodding2 PR to merge (or we can try something else).

pre-commit-ci bot and others added 28 commits October 4, 2024 17:17
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b1a62b6 
for more information, see https://pre-commit.ci
@teuben
ensure rows are in original order when written out (issue #342)
21964dc
@teuben
Merge branch 'nodding2' of https://github.com/GreenbankObservatory/dysh…
02a7a18 
… into nodding2
@teuben
rename NODScan -> NodScan for consistency
b1e59b3
@teuben
- NODScan is not NodScan
ab27d98 
- fix too many feeds in a scan error by looping over the feeds
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f95d79d 
for more information, see https://pre-commit.ci
@teuben
fix more examples now that the error of multiple feeds in a scan has …
01a4c7b 
…gone
@teuben
Merge branch 'nodding2' of https://github.com/GreenbankObservatory/dysh…
af9dc3c 
… into nodding2
@teuben
fix message that needs to be an exception
53137e5
@teuben
fix notebook so it actually runs in CI now
f230e28
@teuben
update so dysh_data isn't called yet
6dfe4df
@teuben
allow getnod(scan=) to have only one of the nodding scans (like getps…
26cbbfa 
…) and figure out the other
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5ae4b9d 
for more information, see https://pre-commit.ci
@teuben
less confusing messages when using picks the feeds in getnod()
25f5aac
@teuben
Merge branch 'nodding2' of https://github.com/GreenbankObservatory/dysh…
1159733 
… into nodding2
@teuben
make it a single top level notebook for CI
af07e3d
@teuben
cleaned up, ready for expansion into a figure version
a76f11e
@teuben
more verbose in terms of checking for valid feeds during nodding
0c33b19
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e44fa09 
for more information, see https://pre-commit.ci
@teuben
more testing
5488a89
@teuben
Merge branch 'nodding2' of https://github.com/GreenbankObservatory/dysh…
ccdab26 
… into nodding2
@teuben
minor language tweaks, and now saved with all figures
6421c07
@teuben
Merge branch 'main' into nodding2
502cc49
@teuben
use a pythonic mkdir as pre-commit was complaining
00c9f31
@teuben
Merge branch 'nodding2' of https://github.com/GreenbankObservatory/dysh…
f534aea 
… into nodding2
@teuben
Merge pull request #395 from GreenBankObservatory/nodding2
21a520b 
Nodding2
@astrofle
Fix: gettp does not separate IFs
1140fb3
@astrofle
Fix: merge conflicts
9464828
@astrofle astrofle merged commit 4681fc0 into main Oct 9, 2024
14 checks passed
@astrofle astrofle deleted the issue_361 branch October 9, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpound mpound mpound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gettp() does not separate the IF's in a nodding example
3 participants
@astrofle @mpound @teuben