Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: close httpx.client after download #387

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Fix: close httpx.client after download #387

merged 5 commits into from
Oct 9, 2024

Conversation

astrofle
Copy link
Collaborator

@astrofle astrofle commented Sep 21, 2024 •
edited
Loading

Fixes issue #338 by closing the httpx.client after the download is finished.

@astrofle astrofle linked an issue Sep 21, 2024 that may be closed by this pull request
ReadTheDocs raises new warnings #338
Closed
@astrofle astrofle requested a review from vcatlett September 25, 2024 00:01
@astrofle astrofle requested a review from tchamberlin October 7, 2024 17:38
vcatlett
vcatlett approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@vcatlett vcatlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

@astrofle astrofle merged commit 0a66554 into main Oct 9, 2024
14 checks passed
@astrofle astrofle deleted the issue_338 branch October 9, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcatlett vcatlett vcatlett approved these changes

@tchamberlin tchamberlin Awaiting requested review from tchamberlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReadTheDocs raises new warnings
2 participants
@astrofle @vcatlett