196 selection class #205
Merged
196 selection class #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. allow quantities in coordinates 3. generic check_type method (note: should be moved to core.py) 4. general debugging
…eric arrays for exact select
…n time and channel selection
Add recursion to check_type to handle when input is array-like. Add select_channel. Add placeholder for select_time.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the functionality of the selection class, issue #196. It includes the Selection class, documentation of the code, test code in test_selection.py, and an example notebook developer/test_selection.ipynb. This code contains ONLY the implementation of the selection class, it does not contain how that class is used by GBTFITSLoad or ultimately flagging. Happy selecting!