Provide default value for plnum #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchamberlin
had a problem deploying
to
hatch build
GitHub Actions
Failure
tchamberlin
had a problem deploying
to
hatch build
GitHub Actions
Failure
tchamberlin
had a problem deploying
to
hatch build
GitHub Actions
Failure
tchamberlin
had a problem deploying
to
hatch build
GitHub Actions
Failure
tchamberlin
had a problem deploying
to
hatch build
GitHub Actions
Failure
tchamberlin
had a problem deploying
to
hatch build
GitHub Actions
Failure
tchamberlin
had a problem deploying
to
hatch build
GitHub Actions
Failure
tchamberlin
had a problem deploying
to
hatch build
GitHub Actions
Failure
tchamberlin
had a problem deploying
to
hatch build
GitHub Actions
Failure
tchamberlin
had a problem deploying
to
hatch build
GitHub Actions
Failure
tchamberlin
had a problem deploying
to
hatch build
GitHub Actions
Failure
tchamberlin
had a problem deploying
to
hatch build
GitHub Actions
Failure
|
As we know, plnum can depend on fdnum so this code will need checks for consistency of inputs. Also should probably have a default kwargs_opts["plnum"] = 1 as with other params. I will approve this for now to fix the immediate bug, and revisit the code more comprehesively later. |
|
actually, this simple fix breaks the test code TestSubBeamNod::test_compare_with_GBTIDL So let's leave #153 open, close this PR, and I can fix the test code on this branch and re-open it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #153, this simply adds (what I hope is) a sensible default value for
plnum