Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for getspec #147

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Fix for getspec #147

merged 3 commits into from
Dec 6, 2023

Conversation

astrofle
Copy link
Collaborator

@astrofle astrofle commented Dec 4, 2023

getspec was not working after the changes made to support multiple fits files.
We are using this function to test the baseline removal.

I'm setting the PR to go to main, but I'm not sure that is what we want.

Changed index selection to be self consistent with function call for getspec
Copy link
Collaborator

@mpound mpound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ultimately the test should check the the correct spectrum was fetched. This could perhaps be done by comparing header information or data to what is expected. I'll approve this but please submit an issue to upgrade this test.

@astrofle astrofle mentioned this pull request Dec 4, 2023
@tchamberlin tchamberlin merged commit 99e826c into main Dec 6, 2023
13 checks passed
@tchamberlin tchamberlin deleted the getspec_patch branch December 6, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants