-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multifits #110
Closed
Closed
Multifits #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix syntax error in release.yaml Can't say for sure that the release action works as intended, but it at least appears to have stopped causing syntax errors
Hatch: - Add test envs - Add [dev] and [docs] optional-dependencies "features" - Add new scripts for easy linting/testing/doc-building Linting/tooling: - Expand ruff linting rule selections - Replace isort config; replace with ruff - Remove pyright config pre-commit: - No longer using isort; replaced with ruff - Tweaks to black args - Update pip-compile step so it works with pyproject.toml (installs all optional dependencies and dumps them to requirements.txt) - Run $ pre-commit auto-update
Note: there are currently 27 linting errors from ruff. I am leaving these in here; they will need to be either fixed, or skipped using '$ SKIP=ruff git commit ...' before further commits can be made
Tweak a few linting settings
Disable ruff pre-commit hook in github action, since it is currently failing
It's currently failing due to issues that I'm not qualified to fix Also, merged docs and dev in optional-dependencies Renamed matrix test runner
These changes look great, thanks for all the work!
Adds Evan's development branch (evan-devel) to the list of triggering branches.
Update python-package.yml
… multifits overwrite conflicts
There are two issues with pre-commit here:
A potential path forward:
That way you have the same formatting applied on both branches, which should remove any formatting-specific diffs/conflicts Note that this will only be an issue short term, because we still don't have the pre-commit hooks run/enforced on all branches |
Thanks, I will do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean merge of multifits into release 0.2.0