-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JSON examples from artifacts #450
Open
YaSuenag
wants to merge
4
commits into
Green-Software-Foundation:dev
Choose a base branch
from
YaSuenag:pr/remove-jsons
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes Green-Software-Foundation#440 Signed-off-by: Yasumasa Suenaga <[email protected]>
Signed-off-by: Yasumasa Suenaga <[email protected]>
Signed-off-by: Yasumasa Suenaga <[email protected]>
Signed-off-by: Yasumasa Suenaga <[email protected]>
1 task
29 tasks
This was referenced May 7, 2024
This a stale pull request. Please review, update or/and close as necessary. |
10 tasks
21 tasks
45 tasks
34 tasks
17 tasks
This PR conflicts current |
11 tasks
22 tasks
16 tasks
This was referenced Oct 8, 2024
22 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
#440
Summary
Remove data source and location source JSONs from artifacts.
These JSONs are no longer provided from both CLI and WebAPI includes container image, but we can use them of course if we need because JSONs are still kept in the repo.
Changes
Essense of this PR is following:
data-sources/
fromItemGroup
, anddata-sources/json
would be created in publish directory.location-sources/
fromItemGroup
, andlocation-sources/json
would be created in publish directory.test-data-azure-emissions.json
is no longer set by default.dotnet tool run
for generating OpenAPI document.data-sources
andlocation-sources
.data-sources
andlocation-sources
, but they would be created into publish directory.This PR has other changes, but they are for test cases because they depends JSON data source and location source.
Note that I commented out test case for ElectricityMapsFree in both src/CarbonAware.WebApi/test/integrationTests/CarbonAwareControllerTests.cs and src/CarbonAware.WebApi/test/integrationTests/LocationsControllerTests.cs because IntegrationTestingBase.cs does not have configuration for ElectricityMapsFree. I will fix it after this PR.
Checklist
Are there API Changes?
No
Is this a breaking change?
This PR breaks current behavior. CASDK is no longer refer test-data-azure-emissions.json for data source and azure-regions.json for location source. CASDK requires the user to configure data source at least.