Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serializer gf #7

Merged
merged 4 commits into from
May 18, 2022
Merged

Serializer gf #7

merged 4 commits into from
May 18, 2022

Conversation

gregoryjflaherty
Copy link
Contributor

@gregoryjflaherty gregoryjflaherty commented May 18, 2022 •
edited
Loading

Features

  1. Change .each to .map so POROs save data
  2. Serialize data by adding user object to Serializer
  3. Add json contract
    resolves Create Serializer for workouts and users #38
    resolves Create POROs objects for workout, user, exercise and interval #39

Concerns

  1. No current concerns

Pre-Submittal Checklist

  • [X ] All tests pass on local
  • [X ] Visually confirm view functionality
  • [X ] No prys or save_and_open_page commands remain
  • [X ] Unnecessary commented code removed

As a GIF, how does this PR make you feel?

so-whats-our-next-move-next-move

@gregoryjflaherty gregoryjflaherty added the enhancement New feature or request label May 18, 2022
@SullyBirashk
Copy link
Collaborator

Great Change, didn't realize it actually wasn't saving the data!

@SullyBirashk SullyBirashk merged commit 4b89ace into main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@samlsmith424 samlsmith424

@SullyBirashk SullyBirashk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create POROs objects for workout, user, exercise and interval Create Serializer for workouts and users
3 participants
@gregoryjflaherty @SullyBirashk @samlsmith424