Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing use of store with useQuery for content packs. #21358

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

dennisoelkers
Copy link
Member

Description

Motivation and Context

This PR is fixing an issue with loading/refreshing content pack revisions/installations on the content pack details page by replacing the use of the Reflux store with useQuery.

Fixes #21122.

/nocl Fixes bug in unreleased change.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers marked this pull request as ready for review January 15, 2025 14:36
Copy link
Contributor

@thll thll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say much about the code, as it's mostly frontend. But it fixes the issue for me 👍 . Thank you @dennisoelkers!

@dennisoelkers dennisoelkers merged commit 04214af into master Jan 20, 2025
7 checks passed
@dennisoelkers dennisoelkers deleted the refactor/replace-content-packs-store branch January 20, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content Pack Installations Section Not Populating
3 participants