Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISW: Contextual warning on stream creation #21303

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

grotlue
Copy link
Contributor

@grotlue grotlue commented Jan 9, 2025

Description

closes #21101
/nocl

This PR adds a contextual warning on stream creation when:

  • selecting the default index set
  • selecting an index set already associated with another stream

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Screenshot 2025-01-08 at 17 24 05
Screenshot 2025-01-08 at 17 24 17

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@grotlue grotlue requested review from ousmaneo and gally47 January 9, 2025 13:02
@grotlue grotlue linked an issue Jan 9, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISW - Stream Creation: Contextual warning
1 participant