Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, document, and update npm dependencies and tooling; fix Bezier-rs demos not building #1857

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Keavon
Copy link
Member

@Keavon Keavon commented Jul 24, 2024

Closes #1853

For a reason I couldn't determine, running npm ci && before the rest of these three commands would fail in CI, unable to find vite that should have been installed in node_modules:

"build-dev": "npm run wasm:build-dev && vite build",
"build-profiling": "npm run wasm:build-profiling && vite build",
"build": "npm run wasm:build-production && vite build",

So I opted to only use npm ci (via npm run setup) in the dev server commands, but keep the npm ci step in the GitHub Actions workflows and the Bezier-rs web demos website/other/build.sh script.

@Keavon Keavon force-pushed the update-dev-tooling branch 3 times, most recently from 73f8995 to 3456ba1 Compare July 24, 2024 22:07
@Keavon Keavon force-pushed the update-dev-tooling branch 3 times, most recently from bae1e00 to 7108458 Compare July 24, 2024 22:51
@Keavon Keavon force-pushed the update-dev-tooling branch 2 times, most recently from 9dfc174 to 9561be7 Compare July 24, 2024 23:00
@Keavon Keavon merged commit f064427 into master Jul 25, 2024
3 checks passed
@Keavon Keavon deleted the update-dev-tooling branch July 25, 2024 00:21
Keavon added a commit that referenced this pull request Jul 25, 2024
… demos not building (#1857)

Fix, document, and update npm dependencies; fix Bezier-rs demos not building

Closes #1853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bezier-rs interactive demos not deploying on website
1 participant