Add Guild Import Modal #499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new `useGuildXYZListGuilds` hook that makes two API calls to `api.guild.xyz`. The hook fetches a user's joined guilds and loads their respective guild information. As of this commit, this functionality is not yet supported by the `@guild/sdk`.
|
This looks amazing at first glance. Going to test a bit further and do a more thorough review. Nice job @amrro ! |
|
@amrro minor conflicts after we merged in a few other PRs. |
# Conflicts: # apps/protocol-frontend/src/contexts/OverlayContext.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear Ticket
Description
This PR adds a Guild Import modal that loads associated joined guilds using the user's signed-in address. Unfortunately, as of this PR, the
@guild/sdkdoes not support fetching guilds joined by the user, so an alternative approach has been taken.Considerations:
There is an ongoing discussion regarding whether we should continue using NATS servers or switch to a Database SQL approach. This decision requires a collective assessment of the costs and benefits of continuing with NATS or opting for a readily conventional method.
It's recommended to monitor PR #364 to ensure its alignment with this job addition.
Screencaptures