-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground elements #226
base: master
Are you sure you want to change the base?
Playground elements #226
Conversation
… and badge with bugs
Hi I've reviewed and tried it out, there are a few concerns about this that we need to sort out before we can release this. I was trying this with the v3 to see how it will work for us as we change the code. Here are some concerns to be addressed , more for maintenance concerns. The biggest one is that i can't get it to show when deployed to amplify as a static site. I think @saiutkarsh33 has tried to import the playground elements in preview.ts, but the ide just doesnt load well and had to workaround to load it as a script tag from node_modules. But the static deployment of storybook does not detect to add the playground-elements package to the final bundle. So i cant make it appear during deployment. Other concerns are whether the maintenance overload for this IDE is worth the effort :
Possible solution is to set Storybook env variables to set the latest published version or to pull from package.json's version.
|
📖 Description