Add initial implementation of zCVobAnimate #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaXt0r
suggested changes
Mar 28, 2024
There was a problem hiding this comment.
Unfortunately I couldn't find an object which has this animation.
I also don't like we introduce certain MorphMesh parameters for PrepareMeshFilter(), yes, some of them are legacy of mine, but we need to be clear here.
I will check it during Easter and try to optimize.
…o check dynamically if an mmb is set.
…alculation needs.
JaXt0r
reviewed
Mar 29, 2024
There was a problem hiding this comment.
Hey hey. I changed your wobble grass branch a little.
- The complains about AbstractMeshBuilder were more on my side. I improved the parameters a little.
- You were kind of lazy, my friend. :-D HeadMorph contains VobAnimate logic... Tststs. 🤣 - I created a subclass for both.
Please check briefly and once ok for you, you can merge.
JaXt0r
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial implementation of zCVobAnimate