Feature/OcMobProperImplementation #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JucanAndreiDaniel
added
feature
JaXt0r
approved these changes
Mar 23, 2024
Make CreateFire load the vobtree
JucanAndreiDaniel
force-pushed
the
feature/ocmobfire-proper-implementation
branch
from
083cfe3
to
2bb9e3f
Compare
JaXt0r
approved these changes
Mar 24, 2024
There was a problem hiding this comment.
Works. But! You have Particles disabled in FeatureFlags. Something you want to add to Production ready or want to have it disabled for releases for now?
Hint: If you want to enable it by default, please also check if the other Particles (e.g. leaves in forest) are working as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make CreateFire load the vobtree
To test
Checklist
Testing