Feature/more externals #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaXt0r
reviewed
Jan 29, 2024
| { | ||
| Debug.LogError(e); | ||
| audioClip = AudioClip.Create("Sound", 1, 1, 44100, false); | ||
| audioClip.SetData(new float[] { 0 }, 0); // almost empty audio |
There was a problem hiding this comment.
Why setting an empty one instead of stopping the clip creation fully?
Please also name an example of a file which isn't loadable.
Assets/GothicVR/Scripts/Npc/Actions/AnimationActions/LookAtNpc.cs
Outdated
Show resolved
Hide resolved
Assets/GothicVR/Scripts/Npc/Actions/AnimationActions/TurnToNpc.cs
Outdated
Show resolved
Hide resolved
ExtWldInsertItem ExtWldGetMobState ExtWldIsTime ExtWldGetDay ExtWldSetTime ExtNpcCanSeeNpc ExtNpcPerceptionDisable ExtNpcGetDistToWp ExtNpcHasEquippedRangedWeapon ExtNpcGetEquippedRangedWeapon ExtNpcHasEquippedMeleeWeapon ExtNpcGetEquippedMeleeWeapon ExtNpcHasEquippedArmor ExtHlpGetInstanceId ExtAiLookAt ExtAiLookAtNpc ExtContinueRoutine ExtPlayAniBs ExtTurnToNpc
…t have a typo in the scripts
…tNextWp ExtNpcGetTalentValue
TA Removed Externals: ClearInventory
JucanAndreiDaniel
force-pushed
the
feature/more-externals
branch
from
c921855
to
acf9c38
Compare
…dling for ZS_Loop()
JaXt0r
suggested changes
Jan 30, 2024
| { | ||
| var props = GetProperties(npc); | ||
|
|
||
| //TBD |
There was a problem hiding this comment.
I always put a "FIXME" as a comment. This helps searching for it in the future. (And I also highlighted the FIXMEs in bright blue to see them instantly): https://rider-support.jetbrains.com/hc/en-us/community/posts/360009890900-Are-FIXME-comments-supported-in-Rider-Can-only-see-TODO-items
JaXt0r
suggested changes
Jan 31, 2024
JaXt0r
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more externals
For animation we need to properly test if it works