-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sky improvements #294
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JucanAndreiDaniel
force-pushed
the
feature/sky-improvements
branch
from
January 21, 2024 15:12
df49034
to
0d4a9e9
Compare
JaXt0r
suggested changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested:
- 16:30 - rain starts, clouds are moving fast
- 00:00 - Texture swapping, clouds aren't moving
Questions:
- Is it intended, that rain and skybox always starts at the same game time when I boot the game?
- Why are clouds moving fast at ~16 but not at ~00?
- The texture swap at midnight: Is it smooth in original G1 or also a plop like in GVR?
Assets/GothicVR/Resources/Prefabs/UI Element Prefabs/VRPlayer.prefab
Outdated
Show resolved
Hide resolved
…dle it via FeatureFlag "production reset" already.
JaXt0r
approved these changes
Jan 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standalone can be built again and the two mentioned times produce Barrier outcomes as expected. You're good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sky v2 - rain implemented, new texture per day, fog colors from INI
To test
Testing