Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sky improvements #294

Merged
merged 14 commits into from
Jan 27, 2024
Merged

Feature/sky improvements #294

merged 14 commits into from
Jan 27, 2024

Conversation

JucanAndreiDaniel
Copy link
Contributor

Sky v2 - rain implemented, new texture per day, fog colors from INI

To test

  1. Set time to 16:25 and see if it rains at 16:30 to 17:30
  2. Set time to 23:59 and see if the proper textures appear during the day (gray clouds)

Testing

  • Tested with PCVR
  • Tested with Pico / Quest

@JucanAndreiDaniel JucanAndreiDaniel added the feature New feature label Jan 21, 2024
@JucanAndreiDaniel JucanAndreiDaniel self-assigned this Jan 21, 2024
@JucanAndreiDaniel JucanAndreiDaniel marked this pull request as ready for review January 21, 2024 22:19
Copy link
Contributor

@JaXt0r JaXt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  • 16:30 - rain starts, clouds are moving fast
  • 00:00 - Texture swapping, clouds aren't moving

Questions:

  1. Is it intended, that rain and skybox always starts at the same game time when I boot the game?
  2. Why are clouds moving fast at ~16 but not at ~00?
  3. The texture swap at midnight: Is it smooth in original G1 or also a plop like in GVR?

Assets/GothicVR/Scripts/Data/SkyState.cs Show resolved Hide resolved
Assets/GothicVR/Scripts/Data/SkyState.cs Show resolved Hide resolved
Assets/GothicVR/Scripts/Data/SkyState.cs Show resolved Hide resolved
Assets/GothicVR/Scripts/Data/SkyState.cs Show resolved Hide resolved
Assets/GothicVR/Scripts/Manager/SkyManager.cs Outdated Show resolved Hide resolved
Assets/GothicVR/Scripts/Manager/SkyManager.cs Show resolved Hide resolved
Assets/GothicVR/Scripts/Manager/SkyManager.cs Show resolved Hide resolved
Assets/GothicVR/Scripts/Manager/SkyManager.cs Outdated Show resolved Hide resolved
Assets/GothicVR/Scripts/Manager/SkyManager.cs Show resolved Hide resolved
JaXt0r

This comment was marked as resolved.

Copy link
Contributor

@JaXt0r JaXt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standalone can be built again and the two mentioned times produce Barrier outcomes as expected. You're good to go.

@JucanAndreiDaniel JucanAndreiDaniel merged commit 4289247 into main Jan 27, 2024
@JucanAndreiDaniel JucanAndreiDaniel deleted the feature/sky-improvements branch January 31, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants