-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 96/dialog subtitles #166
Conversation
…ng (dialogs won't be clipped by world anymore)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature. I really like you understood all the magic with Adapter + GameData + ...
Please check my code improvement comments.
Assets/UnZENity-Core/Scripts/Npc/Actions/AnimationActions/Output.cs
Outdated
Show resolved
Hide resolved
Assets/UnZENity-Core/Scripts/Npc/Actions/AnimationActions/Output.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done. Go on in merging it.
Co-authored-by: Jucan Daniel <[email protected]>
This is the first V1 of Subtitles change, not resolving the issue yet as there are still some things left to do. |
TODOs