Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 96/dialog subtitles #166

Merged
merged 19 commits into from
Oct 15, 2024
Merged

Feature 96/dialog subtitles #166

merged 19 commits into from
Oct 15, 2024

Conversation

BoroBongo
Copy link
Contributor

@BoroBongo BoroBongo commented Oct 12, 2024

TODOs

  • Subtitles for NPCs should be visible above their head and are rotated towards us (As we can't move in the future it will be a fixed value when dialog starts)
  • Subtitles for our hero
    • should be slightly below our view (golden cut or so)
    • They should have a delay when moving with us for convenience (you can reuse the Chapter switch screen logic - there's a movement delay implemented already) - HVRIntroduceChapter.cs
  • Dialog settings can be altered on our MainMenu
  • (Bonus) We can also read and write the subtitle setting from gothic.ini. The ini file is already read in our game. We just need to implement the save as well. - Please read+save the settings inside PlayerPrefsManager then

@BoroBongo BoroBongo linked an issue Oct 12, 2024 that may be closed by this pull request
6 tasks
@BoroBongo BoroBongo marked this pull request as ready for review October 13, 2024 03:10
Copy link
Contributor

@JaXt0r JaXt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature. I really like you understood all the magic with Adapter + GameData + ...
Please check my code improvement comments.

Copy link
Contributor

@JaXt0r JaXt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added a second Audio Listener to the additional camera. Please check if you can remove it as it clutters the log.

image

Copy link
Contributor

@JaXt0r JaXt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It seems like all the CutsceneLibrary entries can't be parsed fully. Can you briefly check in with Luis if this is ok? If yes, we just do these warnings to > /dev/null, of not, maybe he can provide some help.

Copy link
Contributor

@JaXt0r JaXt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Something is wrong when spawning Diego only.

This line of code crashes:

                // We need to look through all RootGOs and fetch the first matching HVRDialog Component.
                _subtitlesComponent = scene.GetRootGameObjects()
                    .Select(i => i.GetComponentInChildren<VRSubtitles>())
                    .First(i => i != null);

Copy link
Contributor

@JaXt0r JaXt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Some .meta files are missing. We need to commit them. Otherwise Scenes/Prefabs can't correlate .cs Components with their appropriate .cs files.

Copy link
Contributor

@JaXt0r JaXt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Go on in merging it.

@BoroBongo BoroBongo removed a link to an issue Oct 15, 2024
6 tasks
@BoroBongo
Copy link
Contributor Author

This is the first V1 of Subtitles change, not resolving the issue yet as there are still some things left to do.

@BoroBongo BoroBongo merged commit a378ef1 into main Oct 15, 2024
2 checks passed
@BoroBongo BoroBongo deleted the feature/borobongo-subtitles branch October 15, 2024 10:15
@BoroBongo BoroBongo mentioned this pull request Oct 15, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants