refactor : 메인페이지 공연 정렬 순서 변경 #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengminy
requested review from
ImNM,
sanbonai06,
cofls6581 and
kim-wonjin
as code owners
sanbonai06
reviewed
Jul 23, 2023
Comment on lines
+58
to
+59
| .where(eqStatusOpen().and(nameContains(keyword))) | ||
| .orderBy(createdAtAsc()) |
sanbonai06
reviewed
Jul 23, 2023
Comment on lines
+64
to
+67
| final long remainingSize = Math.max(pageable.getPageSize() - openEvents.size(), 0); | ||
| if (remainingSize > 0) { | ||
| openEvents.addAll(queryClosedEventsByKeywordAndSize(keyword, pageable, remainingSize)); | ||
| } |
There was a problem hiding this comment.
정렬 순서가 앞 뒤로 달라서 어쩔 수 없이 쿼리를 두번 쏴서 페이징하는데
OPEN 상태인 공연 개수 결과를 세서 pageSize 보다 작으면
pageSize - OPEN 공연수 계산해서 나머지 개수만큼 limit 해서 CLOSED 공연을 가져오는 로직입니다
근데 이미 OPEN 공연을 pageSize 만큼 전부 가져왔을 수도 있으니
그 때는 CLOSED 공연 가져오는 쿼리 안날라가도록 조건문으로 최적화 했습니다~
sanbonai06
approved these changes
Jul 23, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
진행중인 공연: 등록일 순서 (by createdAt)지난 공연: 공연일 순서 (by startAt)변경로직
domain/event