Fix offset for violation when final newline is missing (pinterest#2407)

Closes pinterest#2391
Goooler · Dec 3, 2023 · 814a126 · 814a126
1 parent 85ed6bf
commit 814a126
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/rules/FinalNewlineRule.kt b/...-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/rules/FinalNewlineRule.kt
@@ -36,7 +36,7 @@ public class FinalNewlineRule :
             val lastNode = lastChildNodeOf(node)
             if (insertFinalNewline) {
                 if (lastNode !is PsiWhiteSpace || !lastNode.textContains('\n')) {
-                    emit(0, "File must end with a newline (\\n)", true)
+                    emit(node.textLength - 1, "File must end with a newline (\\n)", true)
                     if (autoCorrect) {
                         node.addChild(PsiWhiteSpaceImpl("\n"), null)
                     }

diff --git a/...ndard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/rules/FinalNewlineRuleTest.kt b/...ndard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/rules/FinalNewlineRuleTest.kt
@@ -32,7 +32,7 @@ class FinalNewlineRuleTest {
                 """.trimIndent()
             finalNewlineRuleAssertThat(code)
                 .withEditorConfigOverride(FINAL_NEW_LINE_REQUIRED)
-                .hasLintViolation(1, 1, "File must end with a newline (\\n)")
+                .hasLintViolation(2, 1, "File must end with a newline (\\n)")
                 .isFormattedAs(formattedCode)
         }