Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tar): data race fix #9309

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

idsulik
Copy link
Contributor

@idsulik idsulik commented Feb 10, 2024

Fixes: #9308

Description
Found and fixed data race condition in tar.go

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 63.54%. Comparing base (290280e) to head (c2109d5).
Report is 1133 commits behind head on main.

❗ Current head c2109d5 differs from pull request most recent head c391b0d. Consider uploading reports for the commit c391b0d to get more accurate results

Files Patch % Lines
pkg/skaffold/util/tar.go 63.63% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9309      +/-   ##
==========================================
- Coverage   70.48%   63.54%   -6.94%     
==========================================
  Files         515      635     +120     
  Lines       23150    32804    +9654     
==========================================
+ Hits        16317    20846    +4529     
- Misses       5776    10349    +4573     
- Partials     1057     1609     +552     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@idsulik
Copy link
Contributor Author

idsulik commented Apr 13, 2024

@ericzzzzzzz Hi!
Should I do anything else or I just need to wait?

@ericzzzzzzz ericzzzzzzz added the kokoro:run runs the kokoro jobs on a PR label Apr 13, 2024
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 13, 2024
@ericzzzzzzz ericzzzzzzz added the kokoro:run runs the kokoro jobs on a PR label Apr 15, 2024
@ericzzzzzzz
Copy link
Contributor

Thank you for the fix!

@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 15, 2024
@idsulik
Copy link
Contributor Author

idsulik commented Apr 16, 2024

p.s. pushed an empty commit to restart the failed job

@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Apr 16, 2024
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Apr 16, 2024
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Apr 16, 2024
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Apr 16, 2024
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Apr 16, 2024
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Apr 16, 2024
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Apr 17, 2024
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Apr 17, 2024
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Apr 17, 2024
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Apr 17, 2024
@ericzzzzzzz ericzzzzzzz merged commit 56746fe into GoogleContainerTools:main Apr 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data race in tar.go
3 participants