[metric] #4 Initialize count metrics on reconciler start #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced May 30, 2024
tiffanny29631
force-pushed
the
count-metric-initialize
branch
from
4ee97b8
to
3c7d49a
Compare
…r start The Count views won't show up in query results until data is sent when error condition happens. This change initialize these metrics and adjust the e2e test to check for Rate aggregation. The public documentation should also be revised to recommend the Rate aggregation for this type of metrics.
tiffanny29631
force-pushed
the
count-metric-initialize
branch
from
3c7d49a
to
f9d46f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Count views won't show up in query results until data is sent when error
condition happens.
This change initialize these metrics and adjust the e2e test to check
for Rate aggregation.
The public documentation should also be revised to recommend the Rate
aggregation for this type of metrics.