Allow configuring enablePlatformTags via plugins.

[tylerscoville]

Continuation of #3518

I'm interested in being able to configure enablePlatformTags via the gradle plugin. I think this is the path to do that as described in #3523 (comment).

[mpeddada1]

Thank you for following up on the contribution @tylerscoville! We will review this week.

[tylerscoville]

@mpeddada1 Thanks for having a look! I pushed some changes to try and up test coverage and clean up the commit history.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

77.3% Coverage
0.0% Duplication

[mpeddada1]

Could we also add an integration test for platform tags in ContainerizerIntegrationTest? Something similar to:

jib/jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/ContainerizerIntegrationTest.java

Line 206 in 9027c8d

public void testSteps_forBuildToDockerRegistry_multipleTags()

[tylerscoville]

I spent a little bit of time on this and will probably need some help updating these tests. I'm not quite sure how to add another platform given the test setup?

[mpeddada1]

@tylerscoville Thanks again! I've added a few comments. Let me know if you have any questions!

[elefeint]

Minor validation question.

[tylerscoville]

@mpeddada1 @elefeint Thank you for the review! Sorry it took me so long to get back to this.

[elefeint]

Looks like adding the new method to RawConfiguration interface broke maven compilation --

Task :jib-maven-plugin:compileJava FAILED
/home/runner/work/jib/jib/jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenRawConfiguration.java:30: error: MavenRawConfiguration is not abstract and does not override abstract method getEnablePlatformTags() in RawConfiguration
public class MavenRawConfiguration implements RawConfiguration {

[ghost]

@tylerscoville THANKS!

I went back and looked at attempting this twice. I kept getting lost in the configuration chain. And the job kept getting me distracted with work things.

I'm still trying to get some other dependencies updated so I can get to multi-arch. Do you need any help on this?

[tylerscoville]

Looks like adding the new method to RawConfiguration interface broke maven compilation --

Task :jib-maven-plugin:compileJava FAILED
/home/runner/work/jib/jib/jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenRawConfiguration.java:30: error: MavenRawConfiguration is not abstract and does not override abstract method getEnablePlatformTags() in RawConfiguration
public class MavenRawConfiguration implements RawConfiguration {

I defaulted the RawConfiguration to return false. Hopefully this gets us past that error 🤞

[tylerscoville]

@elefeint @mpeddada1 Sorry about the long delay on this. Let me know if there is anything else I can do!