Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: --platform flag #380

Merged
merged 5 commits into from
Oct 18, 2023
Merged

feat: --platform flag #380

merged 5 commits into from
Oct 18, 2023

Commits on Oct 16, 2023

  1. feat: --platform flag 

    - for images under test, pass the new --platform flag to pull the
  corresponding image if it is multi-platform capable
- test execution via CreateContainerOptions passes in platform. If
  unset, will default to linux/amd64
    @coopernetes
    coopernetes committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    3c2601a View commit details
    Browse the repository at this point in the history

  2. add e2e tests for --platform usage 

    gofmt tidy

specify correct folder for platform tests
    @coopernetes
    coopernetes committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    bcf1a90 View commit details
    Browse the repository at this point in the history

  3. set default value from host runtime

    @coopernetes
    coopernetes committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    debfcde View commit details
    Browse the repository at this point in the history

  4. update flags section in docs

    @coopernetes
    coopernetes committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    54e7f7a View commit details
    Browse the repository at this point in the history

  5. only need to support linux for running containers 

    MacOS cannot run containers natively. M1/M2 defaults to linux/arm64 so
the "os" field as part of --platform only needs to use linux/ as a
default with GOARCH read in for the particular CPU architecture. Same
deal with Windows, Docker on windows is virtualized Linux (AFAIU)
    @coopernetes
    coopernetes committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    6d65644 View commit details
    Browse the repository at this point in the history