Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start modernizing Okta provider with Go SDK v5 #1939

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brennoo
Copy link
Contributor

@brennoo brennoo commented Oct 19, 2024

This PR modernizes the Okta provider by introducing the Okta Go SDK v5 while maintaining backward compatibility with the existing v2 SDK.

The following generators have been updated to use the v5 SDK:

  • user
  • app_oauth
  • app_swa
  • network_zone

Related to #1936

The code has been simplified by removing unnecessary type assertions and manual filtering, and the accuracy of the generated Terraform resources has been improved.

Further modernization of the remaining resources and the introduction of missing resources will be addressed in future PRs.

Signed-off-by: Brenno Oliveira <[email protected]>
Copy link

@jgalluzzi jgalluzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the okta terraform provider be upgraded as well?

@brennoo
Copy link
Contributor Author

brennoo commented Oct 22, 2024

Can the okta terraform provider be upgraded as well?

it should not be needed as the wrapper gets the version dynamically - I will double check

@brennoo
Copy link
Contributor Author

brennoo commented Oct 22, 2024

yep it gets from your local, for example add this into a provider.tf

provider "okta" {}

terraform {
	required_providers {
		okta = {
                 source = "okta/okta"
	         version = "~> 4.11.1"
		}
  }
}

run terraform init then run your terraformer command to check

Signed-off-by: Brenno Oliveira <[email protected]>
@brennoo
Copy link
Contributor Author

brennoo commented Nov 21, 2024

@sergeylanzman I'm waiting on your review to decide if I continue with this effort :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants