Add location_from_id provider-defined function
#2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `location_from_id` function, tests, docs * Fix whitespace in acc test HCL config [upstream:880aad8f718fff47db62a04c3d39b570069f9bfe] Signed-off-by: Modular Magician <[email protected]>
modular-magician
merged commit 30dcd40
into
GoogleCloudPlatform:FEATURE-BRANCH-provider-functions
1 check passed
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
deleted the
downstream-pr-880aad8f718fff47db62a04c3d39b570069f9bfe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new provider-defined function:
There are unit and acceptance tests for both of these, and documentation
Note about testing
Currently, testing this PR requires downloading an alpha release of TF 1.8.0 and running the acceptance test locally. The unit tests should work fine because they don't use a TF binary like acc tests do, and the dependencies on this branch include provider function support.
I'm working on adding automated testing for the feature branch and provider-defined function PR here: hashicorp/terraform-provider-google#17451
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10061